Repository navigation
docs(shots): link uploaded shots in the pull request description - #98
Merged
Merged
Conversation
The ArchCode pull request page selects shots from Shots links in the PR description instead of matching uploads by branch name (ArchAstro/firstlanding#22847). Tell agents to put the upload's review URL in the description, and how to pin one run. Co-Authored-By: Claude <noreply@anthropic.com>
ark-archastro
marked this pull request as ready for review
November 10, 2026 21:54
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Draft until firstlanding PR 22847 is deployed. The new section says the PR page does not match uploads by branch name, which is true only after that change ships.
Problem and author intent
The ArchCode pull request page used to list every Shots upload stamped with the PR's head branch name. Reused branch names made unrelated shots appear on later PRs. firstlanding PR 22847 replaces that match: the page shows only the runs that the PR description links.
After that change, an agent that uploads shots and never links them gets no gallery on its PR. Nothing in the
shotsskill tells it to add the link.What changed
shots/SKILL.mdsection 6 gains "Link the shots in the pull request description":https://archdev.ai/shots/<owner>/<repo>/<feature>) in the PR description;originrepository and feature name after an automatic upload, whose output the agent does not see;archdev.aiand name the head repository (the fork, for a fork PR).The eight
plugins/*/skills/shots/SKILL.mdcopies are regenerated withnpm run buildintools/plugin-gen.Scope
Documentation only. No CLI or catalog version change.
Risk
Low. Guidance text; linking the Shots URL is harmless before the web change ships.
User impact
Agents that follow the skill add a Shots link to PR descriptions, so their uploads appear on the PR page.
Testing
No end-to-end test applies: this is skill prose with no executable behavior. In
tools/plugin-gen:npm run check(220 generated files match the catalog) andnpm test(139 passed, 1 skipped, 0 failed).Follow-ups
🤖 Generated with Claude Code