Repository navigation
fix(sdk-generator): disambiguate operations that infer the same name - #122
Merged
calvin-archastro merged 1 commit intoNov 1, 2026
Merged
Conversation
PUT /x/{epic}/drafts and PUT /x/{epic}/drafts/{key} both inferred
"replace" on one resource, producing duplicate methods (TS2393) in the
generated SDK. The shallowest path keeps the inferred name; others get a
ByParam suffix.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
calvin-archastro
deleted the
fix/sdk-generator-operation-name-collisions
branch
November 1, 2026 04:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After refreshing the platform spec (#121), regenerating archastro-js fails to compile:
PUT /api/v1/task_epics/{epic}/draftsandPUT /api/v1/task_epics/{epic}/drafts/{key}both infer the operation namereplaceon the samedraftsresource, emitting tworeplacemethods (TS2393: Duplicate function implementation). Python/other backends share the same inferred names.Change
resolveOperationNameCollisionsinresource-inferrer.tsruns after the tree is built. Within one resource, the shallowest path (then alphabetical) keeps the inferred name, so existing SDK surfaces are unchanged. Others get aBy<LastPathParam>suffix (replaceByKey), with a numeric fallback. Deterministic regardless of operation order.Scope / risk / testing
Generator only. Low risk: only affects resources that previously emitted duplicate names (invalid code). New tests in
__tests__/frontend/resource-inferrer.test.ts;npm run build,npm run lint,npm testpass locally; CI runs them on Node 20/22.Follow-up: release a new
@archastro/sdk-generatorso downstream@latestpicks this up.🤖 Generated with Claude Code