Repository navigation
ci(release): hold npm audit to a dated allowlist, accepting picomatch's ReDoS - #527
Merged
Merged
Conversation
…'s ReDoS GHSA-fc5q-39xc-vjpf (published 2026-11-17) covers every picomatch up to 4.0.7, the newest release, so `npm audit --audit-level=high` failed every push to main with no version to move to. picomatch reaches the root and TypeScript worker trees only through vitest and vite, which are not shipped. tools/npm-audit-allowlist.php reads `npm audit --json` for both trees and fails on any HIGH or CRITICAL advisory not in tools/npm-audit-advisories.txt, on a listed one still found after its date, and on a report npm could not produce. The picomatch entry is accepted until 2026-12-18.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHSA-fc5q-39xc-vjpf (published 2026-11-17) covers every picomatch up to
4.0.7, the newest release, so
npm audit --audit-level=highfailed everypush to main with no version to move to. picomatch reaches the root and
TypeScript worker trees only through vitest and vite, which are not shipped.
tools/npm-audit-allowlist.php reads
npm audit --jsonfor both trees andfails on any HIGH or CRITICAL advisory not in tools/npm-audit-advisories.txt,
on a listed one still found after its date, and on a report npm could not
produce. The picomatch entry is accepted until 2026-12-18.