Skip to content

ci(release): hold npm audit to a dated allowlist, accepting picomatch's ReDoS - #527

Merged
AraneaDev merged 1 commit into
mainfrom
fix/audit-allow-picomatch-redos
Nov 18, 2026
Merged

AraneaDev merged 1 commit into
mainfrom
fix/audit-allow-picomatch-redos

Conversation

@AraneaDev

Copy link
Copy Markdown
Owner

GHSA-fc5q-39xc-vjpf (published 2026-11-17) covers every picomatch up to
4.0.7, the newest release, so npm audit --audit-level=high failed every
push to main with no version to move to. picomatch reaches the root and
TypeScript worker trees only through vitest and vite, which are not shipped.

tools/npm-audit-allowlist.php reads npm audit --json for both trees and
fails on any HIGH or CRITICAL advisory not in tools/npm-audit-advisories.txt,
on a listed one still found after its date, and on a report npm could not
produce. The picomatch entry is accepted until 2026-12-18.

…'s ReDoS

GHSA-fc5q-39xc-vjpf (published 2026-11-17) covers every picomatch up to
4.0.7, the newest release, so `npm audit --audit-level=high` failed every
push to main with no version to move to. picomatch reaches the root and
TypeScript worker trees only through vitest and vite, which are not shipped.

tools/npm-audit-allowlist.php reads `npm audit --json` for both trees and
fails on any HIGH or CRITICAL advisory not in tools/npm-audit-advisories.txt,
on a listed one still found after its date, and on a report npm could not
produce. The picomatch entry is accepted until 2026-12-18.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 481ffb63-fa08-4566-9b03-8275e8ac7484
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@AraneaDev
AraneaDev merged commit e9e156c into main Nov 18, 2026
17 checks passed
@AraneaDev
AraneaDev deleted the fix/audit-allow-picomatch-redos branch November 18, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant