Skip to content

LeftCoefficientField & RightCoefficientField schema change from decimal to string - #8

Open
RobertoFrancesconi-AI wants to merge 1 commit into
AquaticInformatics:masterfrom
RobertoFrancesconi-AI:feature/PF-1327_LeftCoefficientField_schema_to_string
Open

LeftCoefficientField & RightCoefficientField schema change from decimal to string#8
RobertoFrancesconi-AI wants to merge 1 commit into
AquaticInformatics:masterfrom
RobertoFrancesconi-AI:feature/PF-1327_LeftCoefficientField_schema_to_string

Conversation

@RobertoFrancesconi-AI

Copy link
Copy Markdown

Decided on a simple hack of changing the schema from a decimal to string. These fields dont appear to be used by the plugin , and its just a case of those fields preventing the xml file from being deserialized.

I think the driver will need more work over time to make it more flexible. If fields can change type a rigid xsd will not suffice.

@BillChen-AI

Copy link
Copy Markdown

@RobertoFrancesconi-AI ,
I'm reviewing the open source projects and came across this PR.
Is this for https://aquaticinformatics.atlassian.net/browse/PF-1505?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants