Fix saved reading progress reverting to an earlier page - #111
Merged
LandWarderer2772 merged 1 commit intoSep 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your saved position can move backwards after you finish reading: a chapter you reached the end of can
reopen on an earlier page and show 99% progress again, or progress can be lost or messed up entirely. This can happen when a slow progress calculation
finishes after the reader has already saved your newer position, replacing that save with older information.
Before writing a recalculated percentage, check that the saved history has not changed since the calculation
started. Keep the check and write together in a short database transaction so a newer save cannot slip
between them. The fix changes one production file, with six net added lines; existing reader save callbacks
and percentage calculations stay as they are.
I compiled the APK and tested it on my phone and an emulator; both are working as expected.
Tests added.