php/phpstan, php/phpcs: fail when the tool finds errors in send-to-file mode

CHANGELOG.md

@@ -1,5 +1,12 @@
 ## [3.0.1] - Unreleased
 
+### Fixed
+- **`php/phpstan/analyse` and `php/phpcs/check` now fail when the tool finds errors in send-to-file mode** (#52)
+  - Both targets appended `|| true` after the output redirect, so the exit code was 0 whether the tool
+    passed or failed and the only signal was the output file
+  - The redirect is kept (output still lands in `phpstan_output_file` / `phpcs_output_file`); the exit
+    code now propagates, matching the non-file path
+
 ### Added
 - **Claude Code skill**: AI-focused skill for MakeBind guidance
   - New `.claude/skills/makebind/SKILL.md` with comprehensive MakeBind documentation

modules/php/phpcs/phpcs.mk

@@ -35,7 +35,7 @@ $(if $(value php_invoke),,$(error phpcs module requires php module - please add
 php/phpcs/check: ## Run PHP CodeSniffer (phpcs_files= for paths, phpcs_args= for extra options)
 	$(eval $@_cmd := $(phpcs_bin) -s $(call phpcs_build_args))
 	$(if $(call mb_is_true,$(phpcs_send_to_file)),\
-		$(eval $@_cmd += > $(phpcs_output_file) 2>&1 || true)\
+		$(eval $@_cmd += > $(phpcs_output_file) 2>&1)\
 		$(call mb_printf_info,Running phpcs and sending output to $(phpcs_output_file))\
 	)
 	$(call php_invoke,$($@_cmd))

modules/php/phpstan/phpstan.mk

@@ -33,7 +33,7 @@ $(if $(value php_invoke),,$(error phpstan module requires php module - please ad
 php/phpstan/analyse: ## Run PHPStan analysis (phpstan_files= for paths, phpstan_args= for extra options)
 	$(eval $@_cmd := $(phpstan_bin) analyse $(call phpstan_build_args))
 	$(if $(call mb_is_true,$(phpstan_send_to_file)),\
-		$(eval $@_cmd += > $(phpstan_output_file) 2>&1 || true)\
+		$(eval $@_cmd += > $(phpstan_output_file) 2>&1)\
 		$(call mb_printf_info,Running phpstan and sending output to $(phpstan_output_file))\
 	)
 	$(call php_invoke,$($@_cmd))