Report what allow added as a pyskills.allowed audit event - #53
Open
ncoop57 wants to merge 1 commit into
Open
Conversation
This was referenced Aug 27, 2026
Open
ncoop57
marked this pull request as ready for review
August 27, 2026 17:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowcollects the(key, entry)pairs it adds to__pytools__and raisespyskills.allowedwith them after the writes. It raises the event once per call, and only when something was new. Recursive calls (dict entries with callable keys,__allow__) report their own additions.Why
A host that approves an
allowcall had no way to learn what the call added. fastaudit's import allowance approves a package's module-levelallowwhile the package initializes.pyskills.allowcarries the arguments, and an entry with a policy cannot be rebuilt from arguments alone. Reporting the result lets safepyrun reconcile its policy fingerprint exactly.Changes
allow: an_addhelper replaces the direct__pytools__[k].addand.updatecalls and records the new entries.Companions
AnswerDotAI/fastaudit#25 records the events its allowance passed. AnswerDotAI/safepyrun#71 reads both.