Stop-Button bei AI-completed() wieder in Textfeld umwandeln#121
Open
Android-PowerUser wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
The implementation correctly addresses the issue where the stop button remained visible after the AI sent completed(). The changes properly introduce the isTaskCompletedByAi flag and use it to control UI state and ignore post-completion streaming chunks. The flag is reset appropriately in resetStreamingCommandState() to ensure new runs function normally. The implementation is clean and follows good practices with no defects that block merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
completed()sendet, bleibt aktuell der Stop-Button sichtbar, obwohl die UI wieder das Eingabefeld zeigen sollte; das führt zu falscher Bedienbarkeit und zu neuen Pending-Antworten bei nachfolgenden Stream-Chunks.Description
isTaskCompletedByAihinzu und berücksichtige sie in der Generierungs-Status-Abfrage (isGenerationRunning()) so dass die UI nicht mehr als "laufend" gilt, sobald die KIcompleted()signalisiert.completed()eintreffende Streaming-Chunks und blockiere deren Erzeugung einer neuen pending AI-Nachricht (aiResultStreamReceiverund Stream-Handler in Offline/Live/Cerebras/Puter/Mistral-Pfaden).Command.CompletedviamarkTaskCompletedByAi(responseText)und aktualisiere die bestehende Modell-Nachricht mit dem finalen Text anstatt eine neue hinzuzufügen (updateLastModelMessageAfterAiCompletion).resetStreamingCommandState()), damit neue Runs normal funktionieren.app/src/main/kotlin/com/google/ai/sample/feature/multimodal/PhotoReasoningViewModel.kt.Testing
./gradlew :app:compileDebugKotlinwurde ausgeführt und war erfolgreich (kein Compile-Error).Codex Task