Skip to content

Initialize SRSHubs reference and update GoBildaPinpoint packet parsing to 32-bit deviceStatus#60

Open
raahilparikh wants to merge 1 commit into
v3-pre-worldsfrom
codex/fix-pose-updating-issue
Open

Initialize SRSHubs reference and update GoBildaPinpoint packet parsing to 32-bit deviceStatus#60
raahilparikh wants to merge 1 commit into
v3-pre-worldsfrom
codex/fix-pose-updating-issue

Conversation

@raahilparikh

Copy link
Copy Markdown

Motivation

  • Ensure the PinpointLocalizer retains the provided SRSHubs instance to avoid null access when issuing commands like IMU reset.
  • Update the GoBilda Pinpoint hub parsing to treat the deviceStatus as a 32-bit value and adjust packet sizing/offsets to match the actual update payload layout.

Description

  • Store the constructor parameter in PinpointLocalizer by adding this.srshubs = srshubs; so hub commands use the instance field.
  • Change SRSHub.GoBildaPinpoint.deviceStatus from short to int and parse it as a 32-bit integer using ByteBuffer.getInt().
  • Adjust getUpdateLength() to return 225 bits and update the bit offsets and padding when extracting deviceStatus to account for a 32-bit field.

Testing

  • Performed a project build with ./gradlew build, which completed successfully.
  • No unit tests were added or modified for these changes.

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant