Switch Pinpoint and APDS sensors to SRSHub layout; add SRSHubSensorLayout helper#55
Open
raahilparikh wants to merge 3 commits into
Open
Switch Pinpoint and APDS sensors to SRSHub layout; add SRSHubSensorLayout helper#55raahilparikh wants to merge 3 commits into
raahilparikh wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GoBildaPinpointDriverusage with the team'sSRSHubwrapper so the Pinpoint odometry and APDS sensors are managed centrally and share consistent I2C configuration and offsets.Description
SRSHubSensorLayoutwhich declares APDS9151 sensor instances, constructs aSRSHub.GoBildaPinpointwith configured offsets and encoder parameters, and exposesensureInitialized(HardwareMap, ...),getLeftHub(),getRightHub(), andgetPinpointHub().PinpointLocalizerto useSRSHubSensorLayout.ensureInitialized(...), to read/reset the Pinpoint viaSRSHubcommands, and to translate the hub-providedpinpointfields intoPose2d/PoseVelocity2d(including unit conversion between mm and inches).GoBildaPinpointDriverimports and logic and replaced them withSRSHubcalls and thepinpointinstance, including IMU recalibration viaSRSHub.GoBildaPinpoint.ResetIMUCommand.Indexerto rely onSRSHubSensorLayout.ensureInitialized(...), obtain hub references viaSRSHubSensorLayout, use the shared staticSRSHub.APDS9151sensor instances, and simplifyupdateSensorCache()to update both hubs each loop and then call eachHolder.updateSensorCache(), removing the previous staggered-update logic.Testing
Codex Task