Repository navigation
Conversation
The release workflow signs taskglass.exe, taskglass_tap.dll and the installer via SignPath when SIGNPATH_ORGANIZATION_ID (variable) and SIGNPATH_API_TOKEN (secret) are set, verifies every signature with Get-AuthenticodeSignature and builds the zip and installer from the signed binaries. Without them the release is built unsigned as before. Adds docs/code-signing.md (EN/ES) with setup steps and artifact configurations. The zip now also ships LICENSE.es.txt. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing without merging: code signing via SignPath is not going ahead for now; staying on 1.3.1 as released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Antivirus (Kaspersky on the maintainer's machine) quarantines the unsigned installer, likely a heuristic false positive because TaskGlass hooks into Explorer. This prepares signing with the free SignPath Foundation programme for open-source projects.
release.ymlsigns the binaries, builds the zip and installer from the signed binaries, signs the installer, and fails if any signature is invalid.SIGNPATH_ORGANIZATION_IDand the secretSIGNPATH_API_TOKENexist, so releases keep working unsigned meanwhile.docs/code-signing.md(EN/ES): application steps, GitHub variables/secrets, and the two SignPath artifact configurations.LICENSE.es.txt.Not testable here: the signing steps run only on a tag with SignPath set up. The workflow YAML parses and the step conditions were checked.
Checklist
gofmt,go vet ./...andgo test ./...pass (no Go changes)🤖 Generated with Claude Code