Skip to content

fix: settings window failed on "apps": null - #15

Merged
AnderCMD merged 1 commit into
mainfrom
fix/apps-null
Nov 20, 2026
Merged

AnderCMD merged 1 commit into
mainfrom
fix/apps-null

Conversation

@AnderCMD

Copy link
Copy Markdown
Owner

What and why

1.2.0 saved "apps": null to config.json when there were no per-app rules (a nil Go slice), and the settings window crashed with "Cannot read properties of null (reading 'length')".

  • config.Parse/Save normalise apps to an empty list; apply keeps copies non-nil.
  • The page also tolerates null from config files already written by 1.2.0.
  • Regression test added.

🤖 Generated with Claude Code

With no per-app rules the app saved "apps": null (nil slice), and the
settings page crashed reading cfg.apps.length. Normalise nil to an empty
list when loading and saving, keep copies non-nil, and make the page
tolerate null from older config files.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 20, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@AnderCMD
AnderCMD merged commit 87387ee into main Nov 20, 2026
1 check passed
@AnderCMD
AnderCMD deleted the fix/apps-null branch November 20, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants