Drop response_source_codes; fix pipeline step lettering + smoke test#6
Open
jacobmpeters wants to merge 1 commit into
Open
Drop response_source_codes; fix pipeline step lettering + smoke test#6jacobmpeters wants to merge 1 commit into
jacobmpeters wants to merge 1 commit into
Conversation
The Usagi source-code projection is now maintained downstream by the OMOP mapping owner, so this repo's OMOP responsibility ends at response_unique_id on relational.responses. - Remove sql/omop/response_source_codes.sql and every reference to it (run_pipeline.sh, docs/omop_run_protocol.md, docs/omop_source_codes.md, sql/omop/README.md). - run_pipeline.sh: drop the create-view step and the stale "type value columns" step (typing was already inlined into the unpivot inserts); re-letter A–G; validate response_unique_id on `responses` (n_unique_id == n_distinct_responses, out_of_omop_range == 0) instead of the removed view. - omop_run_protocol.md: retarget to response_unique_id on responses; validate on responses; fix governance (response_value_as_string) and rollback (drop the --view command; add responses/UDF rollback). - smoke_test_omop_hash.py: rewrite around the response_unique_id UDF contract — compute the id directly (SHA-256 -> first-15-hex -> +offset) in DuckDB and Python and assert equality/range/determinism/uniqueness; drop the surfaced response_hash_id column that the pipeline no longer produces. Smoke test passes; run_pipeline.sh syntax-checks clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the plan to have the Usagi source-code prep maintained downstream, this repo's OMOP responsibility now ends at
response_unique_idonrelational.responses.Drops
response_source_codes(SQL + every reference:run_pipeline.sh,docs/omop_run_protocol.md,docs/omop_source_codes.md,sql/omop/README.md).Also fixes two inconsistencies flagged earlier:
responses(n_unique_id == n_distinct_responses,out_of_omop_range == 0).response_unique_idUDF contract (computes the id directly in DuckDB + Python, asserts equality / OMOP range / determinism / uniqueness); drops the surfacedresponse_hash_idthe pipeline no longer produces.Smoke test passes;
run_pipeline.shsyntax-checks clean. No production data read.