Repository navigation
fix: read and write CLI inventory JSON as UTF-8 regardless of locale - #49
Merged
Merged
Conversation
`labharness scan --output` writes pydantic's model_dump_json output, which keeps non-ASCII characters (e.g. µ, Ω in IDN strings) unescaped. Without an explicit encoding, Path.write_text uses the locale codec and raises UnicodeEncodeError on a cp1252 Windows lab PC; `classify --inventory` likewise mis-decodes a UTF-8 inventory file. Pin both to UTF-8 and add cp1252-simulated regression tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动维护改动
类型：维护（小 bug 修复）
改动：
cli.py的scan --output写入与classify --inventory读取改为显式 UTF-8；pydanticmodel_dump_json保留非 ASCII 字符（如 µ、Ω），在 cp1252 区域设置的 Windows 上原先会 UnicodeEncodeError / 误解码。新增 2 个 cp1252 模拟回归测试（修复前失败、修复后通过；仪器扫描与分类均已 mock，无需硬件）。测试：通过（本地全量 521 passed，ruff check / format 通过）
参考：无
本 PR 由每日维护任务生成，请人工 review 后再合并。
🤖 Generated with Claude Code