Repository navigation
fix: read and write skill markdown as UTF-8 regardless of locale - #48
Merged
Merged
Conversation
save_skill wrote generated skills with the locale default encoding while the skill registry reads them back as UTF-8, so on Windows (cp1252/GBK) a skill containing Ω or µ either failed to save or became unreadable. Example skills fed into the generator prompt were mis-decoded the same way (skills/sot.md already contains non-ASCII text). Both calls now pass encoding="utf-8", with cp1252-simulated regression tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动维护改动
类型：维护（小 bug 修复）
改动：skills/generator.py 的 save_skill 写入与默认示例技能读取改为显式 UTF-8，与 skills/registry.py 的 UTF-8 读取保持一致；在 cp1252 等非 UTF-8 locale 下，含 Ω/µ 的技能此前会保存失败或被误解码（仓库内 skills/sot.md 已含非 ASCII 字符）。新增 2 个模拟 cp1252 的回归测试（修复前失败、修复后通过）。
测试：通过（本地全量 519 passed，ruff check / format 全过）
参考：无
本 PR 由每日维护任务生成，请人工 review 后再合并。
🤖 Generated with Claude Code