Add request timeouts + error handling, and the first tests#1
Open
mkzung wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every one of the 20 API calls in
mcp_server.pyusesrequests.get/post(...)with notimeoutand returnsres.json()with no status or JSON check, andcheck_apikey()raises a non-ToolErrorexception. In a stdio MCP server this means:auto_trace_address, whose own docstring says it may take up to 5 minutes); andToolErrorexceptions), so it never learns it was a bad key, a rate limit, or a bad address.Fix
_request()helper (with_get/_postwrappers) that always sets a timeout and raisesToolErrorwith an actionable message on timeout, transport error, non-JSON body, or an error status (the HTTP code, or the API's{"status": ..., "err_msg": ...}envelope). All 20 tools route through it;auto_trace_addressgets a longer read timeout.check_apikey()now raisesToolErrortoo, naming how to supply the key.hash(a parameter name) as a blockchain protocol, and drop the now-unused exception imports.No API or behavior change on the success path;
pytestis green.