Skip to content

AM-1169 contact: update path for tap icons - #239

Open
fhaver-amsterdam wants to merge 1 commit into
mainfrom
contact/am-1169-icons-update
Open

AM-1169 contact: update path for tap icons#239
fhaver-amsterdam wants to merge 1 commit into
mainfrom
contact/am-1169-icons-update

Conversation

@fhaver-amsterdam

@fhaver-amsterdam fhaver-amsterdam commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Updates the SVG path data for tap-related icons in the contact service so the rendered tap markers use the updated icon shapes/positioning while keeping the existing icon keys stable.

Changes:

  • Updated the tap-fountain-marker SVG path in IconPath.
  • Updated the tap-tap-marker SVG path in IconPath.

Affected services

  • contact

Definition of done

  • API is backwards compatible (make openapi-diff)
  • Swagger UI up-to-date & tested (make dev)
    - [ ] Dependencies updated (make requirements)
    - [ ] Infrastructure config updated (aapp_azure_infra)
    - [ ] Loadtests for relevant endpoints (aapp_testing_loadtests)

After PR created (and deployed on dev):

  • Manual check on dev (o) e.g. use feature via Swagger or admin panel
  • Sanity check on test app (check that dev environment is selected)

Other notes

GitHub Copilot was used in writing the code

@fhaver-amsterdam
fhaver-amsterdam requested review from a team and a lite review from Copilot August 28, 2026 07:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SVG path data for tap-related icons in the contact service so the rendered tap markers use the updated icon shapes/positioning while keeping the existing icon keys stable.

Changes:

  • Updated the tap-fountain-marker SVG path in IconPath.
  • Updated the tap-tap-marker SVG path in IconPath.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants