update icons for taps - #238
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the contact service’s tap-related icon assets and adjusts the repo’s make lint Docker invocation to work in non-interactive environments (e.g., git hooks / CI).
Changes:
- Disable TTY allocation for
lintdocker-compose runs to support non-interactive execution. - Update SVG path definitions for tap marker icons used by the contact service.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Runs the lint service with -T to avoid TTY allocation failures in non-interactive contexts. |
| contact/icons.py | Updates SVG path data for tap-related marker icons. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "tap-fountain-marker": "M16 10C16 6.68629 13.3137 4 10 4C6.68629 4 4 6.68629 4 10C4 13.3137 6.68629 16 10 16V20C4.47715 20 0 15.5228 0 10C0 4.47715 4.47715 0 10 0C15.5228 0 20 4.47715 20 10C20 15.5228 15.5228 20 10 20V16C13.3137 16 16 13.3137 16 10Z", | ||
| "tap-malfunction-marker": "M11.37 14.15L10.25 6.15C10.714 6.15 11.418 6.15 12.01 6.15C12.602 6.15 13.322 6.15 13.754 6.15L12.65 14.15H11.37ZM12.01 17.926C11.082 17.926 10.57 17.238 10.57 16.502C10.57 15.798 11.082 15.078 12.01 15.078C12.938 15.078 13.45 15.798 13.45 16.502C13.45 17.238 12.938 17.926 12.01 17.926Z", | ||
| "tap-tap-marker": "M10.8333 6.16667H13.1667V17.8333H10.8333V6.16667Z", | ||
| "tap-tap-marker": "M0 0H4V20H0V0Z", |
RikSchefferAmsterdam
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Affected services
Definition of done
make openapi-diff)make dev)make requirements)After PR created (and deployed on dev):
Other notes
GitHub Copilot was used in writing the code