Skip to content

AM 1136 boat charing: fix location status - #237

Merged
fhaver-amsterdam merged 4 commits into
mainfrom
boat-charging/am-1136-location-label
Aug 28, 2026
Merged

AM 1136 boat charing: fix location status#237
fhaver-amsterdam merged 4 commits into
mainfrom
boat-charging/am-1136-location-label

Conversation

@fhaver-amsterdam

@fhaver-amsterdam fhaver-amsterdam commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR updates the bridge / boat_charging service to improve how a location’s overall status (OPERATIVE/OCCUPIED/INOPERATIVE) is derived by factoring in a socket “available” signal (notably to handle offline/unavailable charging-station scenarios), and refreshes dependencies and tooling to match the updated behavior.

Changes:

  • Update location status calculation to require both an “operative” connector status and an available flag when determining if a location is OPERATIVE.
  • Adjust the location-detail endpoint to enrich connector data with an available field, and update/add tests + mock responses for the new behavior.
  • Regenerate dependency locks/exports and tweak make lint to run without TTY allocation (for git hooks/CI).

Affected services

  • bridge

Definition of done

  • API is backwards compatible (make openapi-diff)
  • Swagger UI up-to-date & tested (make dev)
  • Dependencies updated (make requirements)
    - [ ] Infrastructure config updated (aapp_azure_infra)
    - [ ] Loadtests for relevant endpoints (aapp_testing_loadtests)

After PR created (and deployed on dev):

  • Manual check on dev (o) e.g. use feature via Swagger or admin panel
  • Sanity check on test app (check that dev environment is selected)

Other notes

GitHub Copilot was used in writing the code

@fhaver-amsterdam
fhaver-amsterdam requested review from a team and a lite review from Copilot August 27, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the bridge / boat_charging service to improve how a location’s overall status (OPERATIVE/OCCUPIED/INOPERATIVE) is derived by factoring in a socket “available” signal (notably to handle offline/unavailable charging-station scenarios), and refreshes dependencies and tooling to match the updated behavior.

Changes:

  • Update location status calculation to require both an “operative” connector status and an available flag when determining if a location is OPERATIVE.
  • Adjust the location-detail endpoint to enrich connector data with an available field, and update/add tests + mock responses for the new behavior.
  • Regenerate dependency locks/exports and tweak make lint to run without TTY allocation (for git hooks/CI).

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
uv.lock Dependency lock updates (multiple package version bumps).
requirements.txt Regenerated exported requirements reflecting updated pinned versions.
Makefile lint target now disables TTY allocation for non-interactive runs.
bridge/boat_charging/views/location_view.py Status derivation updated; location-detail now injects available into connector dicts before computing status.
bridge/boat_charging/tests/views/test_location_views.py Updates/adds tests for new availability-driven status behavior (incl. offline station case).
bridge/boat_charging/tests/mock_data/location_detail.py Updates mock payloads to match new station/connector scenarios under test.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread bridge/boat_charging/views/location_view.py Outdated
@fhaver-amsterdam fhaver-amsterdam changed the title Boat charging/am 1136 location label AM 1136 boat charing: fix location status Aug 27, 2026
@fhaver-amsterdam
fhaver-amsterdam merged commit 778eba4 into main Aug 28, 2026
31 checks passed
@fhaver-amsterdam
fhaver-amsterdam deleted the boat-charging/am-1136-location-label branch August 28, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants