AM-969 city pass: add pass type to passes response - #233
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the city_pass service “passes” response contract to optionally include a pass type, and adjusts test fixtures to reflect the updated source API payload shape.
Changes:
- Added optional
typefield toMijnAmsPassDataSerializerso it is returned (when present) from the passes endpoint. - Refactored test mock data into dedicated modules (
passes,budget_transactions,aanbieding_transactions) and updated tests accordingly. - Updated passes view tests to expect an additional unique budget code (
2024_AMSTEG_PC) in persisted budgets.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| city_pass/serializers/data_serializers.py | Adds optional type field to pass serializer output. |
| city_pass/tests/views/test_data_views.py | Updates tests to use new mock data modules and asserts budgets/type behavior. |
| city_pass/tests/mock_data/passes.py | Updates passes mock payload and adds type to some passes; removes unrelated mock payloads. |
| city_pass/tests/mock_data/budget_transactions.py | Introduces separate mock data module for budget transactions. |
| city_pass/tests/mock_data/aanbieding_transactions.py | Introduces separate mock data module for aanbieding transactions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fhaver-amsterdam
changed the title
RikSchefferAmsterdam
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
city_passservice “passes” response contract to optionally include a passtype, and adjusts test fixtures to reflect the updated source API payload shape.Changes:
typefield toMijnAmsPassDataSerializerso it is returned (when present) from the passes endpoint.passes,budget_transactions,aanbieding_transactions) and updated tests accordingly.2024_AMSTEG_PC) in persisted budgets.Affected services
Definition of done
make openapi-diff)make dev)- [ ] Dependencies updated (make requirements)- [ ] Infrastructure config updated (aapp_azure_infra)- [ ] Loadtests for relevant endpoints (aapp_testing_loadtests)After PR created (and deployed on dev):
Other notes
GitHub Copilot was used in writing the code