feat(onboard): use the existing SSH key instead of generating one per machine - #878
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ghlogin step offered to generate and upload a new SSH key, which would leave one key per machine. I keep one key in 1Password and want every machine to use it through the 1Password SSH agent, which the dotfiles now configure.That agent config lives in the dotfiles, so they can no longer be cloned over SSH on a new machine. The first clone, and the work submodule, now go over HTTPS using the
ghsign-in. Everything after the bootstrap uses SSH as before.Tested the clone path with no global git config and no SSH involved: the private dotfiles repo and its private submodule both clone.