feat(onboard): make setup work on networks that intercept TLS - #877
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a company laptop whose network intercepts TLS,
setup.shfails at its first Bazel download: Bazel's JVM ignoresSSL_CERT_FILEand rejects the proxy's certificate. That is the very first step on a new work machine, before any work-only config exists to fix it.setup.shnow builds a Java truststore fromSSL_CERT_FILEwhen it is set and points Bazel at it in~/.bazelrc. It keys off the standard variable, so nothing company-specific is in this repo and a machine without it is untouched.Tested the certificate split and import on a laptop with such a bundle (129 certificates in, 129 in the store) and that Bazel fetches with the resulting store.
setup.shas a whole has still not been run.