Hub poller: tolerate a bare-list /events response#166
Merged
Conversation
…attribute get)
An agent (e.g. an older/foreign one, or one behind a proxy) that returns a bare JSON
list from /events instead of the canonical {"events": [...]} crashed fetch_events with
"'list' object has no attribute 'get'", so its events were never ingested and the log
was noisy. Add _events_from_payload(): accept a dict or a bare list, filter to dict
elements with an id, and log a clear "unexpected /events response shape" for anything
else instead of the cryptic AttributeError.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An agent that returns a bare JSON list from
/events(instead of the canonical{"events": [...]}) crashedfetch_eventswith'list' object has no attribute 'get'— seen repeatedly in a hub log forSnowLeopard. Its events were never ingested and the log was noisy with the cryptic error.Fix
_events_from_payload(): accept a dict ({"events": [...]}) or a bare list; returnNonefor any other shape so the caller logs a clear "unexpected /events response shape" instead of theAttributeError. Callers filter to dict elements with anid, so a stray non-dict element can't crash the ack filter either.Gates
🤖 Generated with Claude Code