Skip to content

fix(tracing): wire flushSync into the TUI worker exit/SIGINT path (M3 crash-guard never fires in pure-TUI) #875

Closed

Description

@anandgupta42

Found during v0.8.1 release review (CTO, P2). The M3 crash-guard added in #865 only runs when flushSync fires, which is wired in run.ts (CLI SIGINT/exit) but not in worker.ts. In pure-TUI sessions the M3 export-vs-flushSync path is never exercised. Not a regression (no worse than before #865); add a flushSync call in a TUI exit/SIGINT handler so the guard actually protects TUI traces.

Activity

  1. anandgupta42 commented on Nov 5, 2026

    @anandgupta42
    ContributorAuthor

    Closing as fixed on main: The TUI worker now calls traceConsumer.flushSync() during shutdown, and the CLI invokes that shutdown before terminating the worker. Please reopen if you still see this on v0.12.9 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions