Repository navigation
Conversation
Each feature gets its own file under hooks/features/, called by name from features/index.ts in a fixed order: its own hooks, the session and turn events, its band line and its tool-call phases. One tool.call hook (tool-chain.ts) runs Bash and file handling in fixed phases: bashRewrite, bashGate, the call, bashAfter, editAfter, readOrEditAfter. The status line is built from parts (status-line.ts). runTool moves to altimate-cli.ts with a `write` option that goes through the CLI with --allow-write. dbt-command.ts finds the dbt invocations in a shell command line. New userConfig fields: maxScanBytes, healthBlocksPush, healthConfigPath, commentsPollSeconds, commentsInContext. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Subshells after keywords, case patterns, process substitution, arrays, arithmetic and function definitions parse again; quotes in a heredoc inside a substitution are text; a function or case pattern named dbt is not an invocation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t wrote it, keep Re-run complete Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…is per project Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review loop on this PR: two independent reviewers (
Left as known limits (round 2, not fixed): history is kept per session folder (50 runs shared by projects under it); a |
…ead per project folder Where a command ran is read only from plain cd statements; anything the shell could read differently (quotes, variables, subshells, pipes, comments, if, pushd, eval) records nothing instead of another project's run. A run written with --target-path or DBT_TARGET_PATH is read from that folder. A call that runs dbt in several projects records each; reads run together and one failing does not lose the others. Calls that overlap in one artifact folder are not recorded, since the file does not say which command wrote it. History keeps 50 runs per project, newest first by completion. Bare secret names (TOKEN, PASSWORD, KEY) are left out of Re-run. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Review-loop result (Claude + Codex, independent reviewers)Two independent external reviews, then three attack-the-fix gates. Replies to every finding raised against
The last gate's findings were all fixed after it ran and covered by tests, but that last round was not re-gated. 240 plugin tests pass. Demo video (real Claude Code session with this plugin and the altimate-code branch CLI, a dbt-duckdb project): |
|
Final-gate review (independent Claude + Codex CLI reviewers on HEAD). Open, NOT fixed (so this PR stays a draft):
I tried a redesign (any overlapping dbt call in the session blocks recording, no folder comparison, 30-minute staleness for never-ended calls) but could not run the plugin tests here ( |
|
Verify-only gate: no commits since the final-gate review, so nothing new to approve. The three MAJOR findings in the runs.tsx overlap guard stay open and this PR stays a draft until the owner picks the intended trade-off (block on any overlapping dbt call vs. compare per folder). |
…t, in any folder; otherwise Claude is told Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ll over an hour is not recorded Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Replies to the three open MAJOR findings in the
Review of the new commits (Claude + Codex, separate processes) found more, all fixed with tests that fail on the earlier code: bookkeeping ran after an await, so two calls ending together could both look alone; Gate status: the first verify pass on db4f1c1 returned REQUEST CHANGES from both reviewers. The second, on 040d424, returned APPROVED from Claude and REQUEST CHANGES from Codex (the hour-expiry case). That is fixed in 3fd6303 with a test (248 plugin tests pass), but no reviewer has seen it, and the gate's two-pass limit is used up. So this PR stays a draft and has no APPROVED comment. |
…ping it is not recorded Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
review-loop: APPROVED at 2283219 Gate on the overlap-guard fixes: Claude and Codex both APPROVED. A real MAJOR found on the way (a backgrounded dbt call dropped out of the overlap bookkeeping) was fixed in 2283219 with a regression test that fails without the fix; 249 plugin tests pass. Accepted MINOR limits: backgrounding forms not ending in '&' (e.g. '& disown'), 1-hour age-out, 50/500 caps. |
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Incremental review of Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit e8f97f5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e8f97f5)Status: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (6 files)
Previous review (commit 2283219)Status: 6 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (21 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 76.4K · Output: 8.6K · Cached: 578.8K |
…ng feature register no longer drops the tool hook, doc and alias tidy Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
|
||
| import { registerFeatures } from './index' | ||
|
|
||
| test('a feature whose register throws never reaches the caller, so the tool hook after the features still installs', () => { |
There was a problem hiding this comment.
SUGGESTION: The test would pass without the per-feature guard it is named for
Eight of the nine features still have an empty register(on, context) {} (defer, to-model, comments, cost, health, sql-graph, docs, cte-profile), so the proxy is only ever reached by runs and calls is always 1. A single try { ...all nine... } catch {} around the whole block — the case this change exists to prevent, where the first failure stops the rest — also satisfies both assertions, so nothing here shows that one feature's throw leaves the others or installToolChain alive. Once a second feature has a body, make the proxy throw on its first call only and assert the later registers still reached on (calls should equal the number of features, not 2).
| // One feature's register throwing (a duplicate command, a refused matcher) must not stop the others or the tool hook after them. | ||
| try { | ||
| runsRegister(on, context) | ||
| } catch {} |
There was a problem hiding this comment.
SUGGESTION: A feature that fails to register now fails silently
The module header (line 7) says a function that throws "is logged and skipped", but these empty catch {} blocks drop the error: a duplicate command name or a refused matcher makes a feature disappear with nothing in the debug log, where previously the plugin failed loudly at load. failed() needs $, which registerFeatures does not receive, so the failure could be collected here and logged from featuresSessionStart, the first place $ is available. Otherwise the header comment should say register failures are silent.
| } | ||
|
|
||
| export type RunRecord = { | ||
| /** The artifact's invocation id; its completion time when the artifact has none. */ |
There was a problem hiding this comment.
SUGGESTION: The fallback id is no longer just the completion time
toRecord now builds ${view.projectDir ?? ''}\u0000${completedAt} when the artifact has no invocation id (hooks/features/runs.tsx:204), so the id is the project plus the completion time when the artifact has none. Worth saying so here, since this comment is the contract consumers of RunRecord.id read.
|
review-loop: APPROVED at e8f97f5 |
…ompletion time Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
What
Every dbt command Claude runs is recorded with its results, shown in
/runs, and can be re-run through the prompt.build,run,test,seed,snapshot,compile,retryorclone, the plugin calls altimate-code'sdbt_run_resultsand records the run once per invocation id (an unchangedrun_results.jsonis ignored). Up to 50 runs per project are kept in the plugin store; messages are cut to 300 characters, rows to 100 per run, and the whole store is held under 2.5 MB.build: 41 ok, 2 errors: stg_orders, fct_sales./runsopens a pane: one button per run (command, seconds, passed of total); inside a run the failures come first. Re-run fills the prompt with the recorded command; Re-run failed (shown on the newest run when it has failures) fills it withdbt retry.The feature fills in
hooks/features/runs.tsxandRunsStateintypes/index.d.tsonly.Depends on
The companion altimate-code PR (AltimateAI/altimate-code#1729) that implements
dbt_run_results. Merge that one first. This branch also carries the shared foundation commit; retarget or rebase once the foundation lands onmain.Verification
claude plugin test plugins/altimate-code: 212 pass, includinghooks/features/runs.test.tsx(a run recorded once, the same file ignored, the pane on terminal and desktop, Re-run and Re-run failed filling the prompt, the 50-run, row, message and store caps).claude plugin validatepasses.Demo video (hosted)
P-11.mp4 — watch on Notion (Altimate workspace; recorded from the approved head of this PR).
🤖 Generated with Claude Code
Demo video: P-11.mp4 (re-recorded; 58s: dbt_run_results tool on a dbt fixture, then dbt builds in Claude Code and the /runs pane).