Repository navigation
Conversation
Each feature gets its own file under hooks/features/, called by name from features/index.ts in a fixed order: its own hooks, the session and turn events, its band line and its tool-call phases. One tool.call hook (tool-chain.ts) runs Bash and file handling in fixed phases: bashRewrite, bashGate, the call, bashAfter, editAfter, readOrEditAfter. The status line is built from parts (status-line.ts). runTool moves to altimate-cli.ts with a `write` option that goes through the CLI with --allow-write. dbt-command.ts finds the dbt invocations in a shell command line. New userConfig fields: maxScanBytes, healthBlocksPush, healthConfigPath, commentsPollSeconds, commentsInContext. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… allowed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s built Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…commands that set their own target Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Subshells after keywords, case patterns, process substitution, arrays, arithmetic and function definitions parse again; quotes in a heredoc inside a substitution are text; a function or case pattern named dbt is not an invocation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and, skip more commands that change context Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… dbt calls before it Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Review-loop results (independent claude + codex reviews, then three fix-gate rounds)
The allow-list rules from the last gate round, Tests: |
…n linear time Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t --inline, say what the scan limit covers Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n limit covers Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Final review round (independent Codex and Claude reviewers, then a fresh attack-the-fix pass on the fixes). Findings and outcome:
Verdict of the attack-the-fix pass on the fixes: APPROVE. 238 plugin tests pass. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
review-loop: APPROVED at 185f903 (last fix: the value after |
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit 582f9f8)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 582f9f8)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Previous review (commit 185f903)Status: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (21 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 52.1K · Output: 12.9K · Cached: 373.5K |
…r command, and word a just-over scan as over Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… of a scan whose estimate is under the limit Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
| // as not over the limit when the scan is just past it. | ||
| const scanned = | ||
| worst.point <= limitBytes | ||
| ? `up to ${formatBytes(worst.bytes)} (≈ ${worst.display} estimated)` |
There was a problem hiding this comment.
SUGGESTION: The new up to … branch can still print the limit twice.
formatBytes(worst.bytes) is never compared to the limit, so when the upper bound and the limit format into the same 0.1-unit bucket the refusal reads as not over the limit again. With limitBytes = 10 * GIB, point = 10 * GIB and maxBytes = 10 * GIB + 30 * 1024 ** 2, formatBytes(worst.bytes) is 10.0 GiB, so the deny becomes up to 10.0 GiB (≈ 10.0 GiB estimated) would be scanned, over the 10.0 GiB limit. Guard this branch the way the next one guards the display, e.g. fall back to the point display (or just over) when formatBytes(worst.bytes) === formatBytes(limitBytes).
|
review-loop: APPROVED at 7cc430a |
Summary
Adds the cost gate. Before
dbt run,dbt buildordbt showexecutes, the plugin callsdbt_cost_estimate. If the estimated BigQuery scan is over the limit, the command is held until the user allows it. An on-demand estimate command is also available.This branch includes the shared foundation for the dbt Power User features (local branch
feat/pu-mods-foundation). Those commits drop out of the diff once the foundation lands in main.Merge order: the altimate-code PR (AltimateAI/altimate-code#1732) first, because this plugin calls the CLI tool it adds.
Test plan
hooks/features/cost.test.tsxcovers the gate (held over the limit, allowed under it, and on-demand estimates)Demo video (hosted)
P-05.mp4 — watch on Notion (Altimate workspace; recorded from the approved head of this PR).
🤖 Generated with Claude Code