Skip to content

test: handle transient busy fixture removal on Windows #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkimw merged 1 commit into from
Oct 4, 2026
Merged

test: handle transient busy fixture removal on Windows #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/devtools.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ async function fixture(t,{installed=true}={}) {
await initPlugin(directory,{publisher:'author',id:'sample-plugin'});
let linked;
if(installed){const parent=path.join(directory,'node_modules','@altifigence');await fs.mkdir(parent,{recursive:true});linked=path.join(parent,'dds-plugin-sdk');await fs.symlink(sdkRoot,linked,process.platform==='win32'?'junction':'dir');}
t.after(async()=>{if(linked)await fs.unlink(linked);assert.equal(path.dirname(root),await fs.realpath(os.tmpdir()));await fs.rm(root,{recursive:true});});
// Windows can report EBUSY during final directory removal even after the
// owned-process exit assertions pass. Bound cleanup retries without skipping them.
t.after(async()=>{if(linked)await fs.unlink(linked);assert.equal(path.dirname(root),await fs.realpath(os.tmpdir()));await fs.rm(root,{recursive:true,maxRetries:10,retryDelay:100});});
return{root,directory};
}
async function gone(pid) {for(let i=0;i<100;i++){try{process.kill(pid,0);}catch(failure){if(failure.code==='ESRCH')return;throw failure;}await delay(20);}throw Error('Dev child survived cleanup');}
Expand Down