Skip to content

CA1826 (Do not use Enumerable methods on indexable collections) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kirsan31 wants to merge 1 commit into from
Closed

CA1826 (Do not use Enumerable methods on indexable collections) #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/Databento.Client/DataSources/FileDataSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,15 @@ public Task ReconnectAsync(CancellationToken cancellationToken = default)

private SymbolMappingMessage CreateSymbolMappingMessage(SymbolMapping mapping)
{
// Get first interval for instrument ID
var interval = mapping.Intervals.FirstOrDefault();

// When StypeOut is InstrumentId, interval.Symbol contains the numeric ID
uint instrumentId = 0;
if (interval != null && _metadata?.StypeOut == SType.InstrumentId)
// Get first interval for instrument ID and when StypeOut is InstrumentId, interval.Symbol contains the numeric ID
uint instrumentId;
if (mapping.Intervals.Count > 0 && _metadata?.StypeOut == SType.InstrumentId)
{
uint.TryParse(mapping.Intervals[0].Symbol, out instrumentId);
}
else
{
uint.TryParse(interval.Symbol, out instrumentId);
instrumentId = 0;
}

return new SymbolMappingMessage
Expand Down