Repository navigation
feat(jdk12): add demo for JEP 346 - #408
spaultek314 wants to merge 5 commits into
Conversation
AloisSeckar
left a comment
AloisSeckar
left a comment
There was a problem hiding this comment.
Hi @spaultek314 and thank you for your contribution
I find a couple of things that have to be fixed before I can approve and merge your work. Please, have a look. Ask, if you need more info.
| import org.javademos.commons.IDemo; | ||
| import org.javademos.commons.IDemoLoader; | ||
|
|
||
| import org.javademos.java12.jep346.G1PeriodicGCDemo; |
There was a problem hiding this comment.
please, adjust order of the imports so the JEP folders are sorted ascending
| public void demo() { | ||
| info(346); | ||
|
|
||
| System.out.println("G1 Periodic Garbage Collection"); |
There was a problem hiding this comment.
if there is no relevant code to demonstrate a language feature or an API usage, we only use comments in file, not printing out...please turn those into Java comments
check the contribution guide for details if needed
| "name": "JEP 346 - Promptly Return Unused Committed Memory from G1", | ||
| "dscr": "G1 can periodically consider garbage collection during idle periods to return unused committed heap memory to the operating system.", | ||
| "link": false, | ||
| "code": true |
There was a problem hiding this comment.
there will be false (printing out info is not considered a "code" for our purposes)
Updated comments to provide detailed information about JEP 346 and its configuration options.
|
hi, @spaultek314 , are you still planning to work on this issue in different PR? |
Closes #406