Improvements to GCP testing workflow#351
Merged
Merged
Conversation
Adds two opt-in workflow_dispatch inputs to GCP: Test Image so a CIT
fork/branch can be built and used in place of
gcr.io/compute-image-tools/cloud-image-tests:latest:
- cit_git_repo: owner/repo of a CIT fork (empty = use prebuilt)
- cit_git_ref: branch, tag, or SHA (empty = repo default branch)
When cit_git_repo is set, a new build-cit job clones, runs
`docker build`, and publishes the image as a 1-day-retention artifact
(cit-custom-image). The four test jobs each `needs: build-cit`, then
conditionally download + `docker load` the tarball and pass
`image_ref: cit-custom:run-<run_id>` to cit-run-with-retry. The x86_64
per-shape job's load step uses ${{ env.docker_cmd }} so the
podman-based AlmaLinux runner works identically.
The cit-run-with-retry composite action gains an `image_ref` input
(defaulting to the upstream prebuilt) plumbed through to the script as
$CIT_IMAGE; the previously-hardcoded image string in
cit-run-with-retry.sh now reads `${CIT_IMAGE:-<upstream>}`.
When both inputs are empty, behavior is unchanged: build-cit is
skipped, GHA treats skipped needs as non-blocking, the conditional
load steps don't run, and the test jobs pull the upstream image as
before.
test-gcp-nonpershape ran the same `^(lssd|disk|vmspec)$` filter as
test-gcp-initialtest with no gating role and lower parallelism (10s
stagger vs 1s, no parallel_count). The two jobs duplicated coverage,
so keep only initialtest (which the per-shape matrix depends on).
Port the {x86_64,aarch64}_shape_override workflow inputs over: when
set, they now pin the smoke-test shape on test-gcp-initialtest;
otherwise the previous defaults (c4-standard-8 / c4a-standard-8)
apply. Update the input descriptions accordingly.
Drop test-gcp-nonpershape from summarize-quota-failures' needs list;
the matching quota-failures-nonpershape-* artifact group is no
longer emitted.
The `network` test suite is inconsistent (pass/fail varies across reruns of the same shape × image). Drop it from both per-shape filters (x86_64 and aarch64) until the upstream flakiness is sorted.
jonathanspw
force-pushed
the
cit-custom-build
branch
from
c6aaf5a to
a8864d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.