Include platform info in sign task payload packages - #1252
Open
anfimovdm wants to merge 1 commit into
Open
Conversation
Add platform_id and platform_name to each package entry returned by get_available_sign_task() so sign nodes can apply per-platform rules (e.g. requiring file/IMA signatures). Both fields are optional on SignRpmInfo, so older sign nodes are unaffected. Part 1 of AlmaLinux/build-system#546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of AlmaLinux/build-system#546.
Adds
platform_idandplatform_nameto each package entry returned byget_available_sign_task(), so sign nodes know which platform each package belongs to and can apply per-platform rules (e.g. requiring file/IMA signatures).Changes
alws/crud/sign_task.py— extend the existingselectinloadchains withBuildTask.platformand addplatform_id/platform_nameto source and binary RPM package entries.alws/schemas/sign_schema.py— both fields added as optional onSignRpmInfo.Compatibility
.get()and ignore unknown keys — no impact.Testing
New
tests/test_crud/test_sign_task.py: builds a two-platform build with source and binary RPMs and asserts every package in the payload carries the correctplatform_id/platform_name(covers the multi-platform case).Related PRs
🤖 Generated with Claude Code