refactor: converge Review recovery and dashboard delivery - #51
Merged
Conversation
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convergence follow-up to #46 after #47-#50 exposed several layers of Recovery-specific patching.
This PR keeps the Recovery product capabilities but removes duplicate/implicit implementation paths:
afterrow snapshot; legacy events withoutafterstill parse unchanged.CoordinatedReviewServicesnapshots post-write TM state into ReviewDecisionLog events and conservatively compensates a commit if an external log revision race is detected.safe_revertbecomes the single recovery implementation. Freshness evidence resolves in order: recorded after-image -> immutable ReviewIndex -> strict legacy before-image anchor.safe_revert_with_history_fallbackremains only as a compatibility alias./api/review/history/coordinatesowns paged coordinate inspection/search/recovery.server.pyno longer monkey-patchesserver_impl._Handlerat import time. Review history/recovery is a normal handler subclass and DashboardServer uses explicithandler_class/review_service_classcomposition.localizer.web.DashboardServer) composes Review assets with i18n/workflow presentation throughrender_index_html, removing the temporary global-handler swap that could bypass Review UI delivery.Deliberate boundaries:
server_impl.pyremains as the compatibility/base transport implementation; the behavioral facade/monkey-patch layer is what is removed.Refs #46