Skip to content

fix: make Review Recovery UI delivery fail closed - #48

Merged
AllenXiao95 merged 1 commit into
masterfrom
fix/recovery-ui-static-delivery
Sep 3, 2026
Merged

fix: make Review Recovery UI delivery fail closed#48
AllenXiao95 merged 1 commit into
masterfrom
fix/recovery-ui-static-delivery

Conversation

@AllenXiao95

Copy link
Copy Markdown
Owner

Follow-up to #47 / #46 after real Windows Dashboard validation showed that the Recovery backend and static asset were present but the served / page could still omit the Recovery function area silently.

This change makes Recovery UI delivery mandatory at the public dashboard server boundary:

  • preserves the existing HTTP server implementation unchanged in server_impl.py;
  • public server.py re-exports the historical module surface so existing imports continue to work;
  • / injects review-recovery.js explicitly and fail-closed;
  • if the Recovery asset is missing, Dashboard returns HTTP 500 missing_asset instead of silently serving a reduced UI;
  • if index.html cannot accept the injection, it fails with invalid_asset;
  • all existing entrypoints (localizer dashboard, python -m localizer.cli.main, tests) use the patched request handler.

The existing Recovery HTTP smoke test now exercises this public facade and must still find 变更历史 / Recovery in the served HTML.

This is intentionally a delivery fix only; no Review/TM recovery semantics change.

Refs #46

@AllenXiao95
AllenXiao95 merged commit e0c4576 into master Sep 3, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant