fix: make Review Recovery UI delivery fail closed - #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #47 / #46 after real Windows Dashboard validation showed that the Recovery backend and static asset were present but the served
/page could still omit the Recovery function area silently.This change makes Recovery UI delivery mandatory at the public dashboard server boundary:
server_impl.py;server.pyre-exports the historical module surface so existing imports continue to work;/injectsreview-recovery.jsexplicitly and fail-closed;missing_assetinstead of silently serving a reduced UI;index.htmlcannot accept the injection, it fails withinvalid_asset;localizer dashboard,python -m localizer.cli.main, tests) use the patched request handler.The existing Recovery HTTP smoke test now exercises this public facade and must still find
变更历史 / Recoveryin the served HTML.This is intentionally a delivery fix only; no Review/TM recovery semantics change.
Refs #46