Skip to content

feat: FoodRestriction#1865

Merged
dbirman merged 5 commits into
devfrom
1861-foodrestriction
Jul 9, 2026
Merged

feat: FoodRestriction#1865
dbirman merged 5 commits into
devfrom
1861-foodrestriction

Conversation

@dbirman

@dbirman dbirman commented Jun 29, 2026

Copy link
Copy Markdown
Member

Add FoodRestriction class

@dbirman dbirman linked an issue Jun 29, 2026 that may be closed by this pull request
@dbirman
dbirman requested a review from saskiad June 29, 2026 18:05
Comment thread docs/source/components/subject_procedures.md Outdated
Comment thread docs/source/components/subject_procedures.md Outdated
Comment thread docs/source/components/subject_procedures.md Outdated
Comment thread src/aind_data_schema/components/subject_procedures.py Outdated
Comment thread src/aind_data_schema/components/subject_procedures.py Outdated
Comment thread src/aind_data_schema/components/subject_procedures.py Outdated

@saskiad saskiad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, the titles for three fields still say water instead of food. Please fix those.

I assume we've verified these fields with the folks doing food restriction? This looks same as water restriction, and I wouldn't expect them to wildly different, but I could also imagine there being some differences. E.g. sometimes food restriction is about using a different diet - would we want to have a field for what food is used? Or I guess if we have a protocol for food restriction we wouldn't need to specify that if it's always the same thing. But regardless, that's an example - just want to confirm we're not missing something.

@dbirman

dbirman commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

I assume we've verified these fields with the folks doing food restriction? This looks same as water restriction, and I wouldn't expect them to wildly different, but I could also imagine there being some differences. E.g. sometimes food restriction is about using a different diet - would we want to have a field for what food is used? Or I guess if we have a protocol for food restriction we wouldn't need to specify that if it's always the same thing. But regardless, that's an example - just want to confirm we're not missing something.

I'll hold off on merging until we have a chance to chat. I think the current version is fine for what Ines/Vivek did but we may have to make changes later.

@dbirman
dbirman added this pull request to the merge queue Jul 9, 2026
Merged via the queue into dev with commit a267842 Jul 9, 2026
7 checks passed
@dbirman
dbirman deleted the 1861-foodrestriction branch July 9, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FoodRestriction

2 participants