Skip to content

Feature/style adjustments#102

Merged
meganrm merged 95 commits into
mainfrom
feature/style-adjustments
Jun 5, 2026
Merged

Feature/style adjustments#102
meganrm merged 95 commits into
mainfrom
feature/style-adjustments

Conversation

@meganrm

@meganrm meganrm commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Problem

The green callout box was a little too bright

Solution

Changed it to an ALLEN_ORANGE as the border

NOTE: the number of commits is because I squashed merged but this branch was from main before that.

Type of change

Please delete options that are not relevant.

style change

Steps to Verify:

  1. look at the preview and compare to https://www.dropbox.com/scl/fi/epmv1pazbl2uumfevg7ln/Screenshot-2026-06-02-at-3.03.43-PM.png?rlkey=l10kb6cxtfijr42erdtcywdt1&dl=0

Screenshots (optional):

BEFORE:
Screenshot 2026-06-02 at 3 03 43 PM

AFTER:

Screenshot 2026-06-02 at 4 35 53 PM

meganrm and others added 30 commits May 5, 2026 16:30
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mirrors the CSS custom properties in colors.css — adds missing brand
colors (ALLEN_MAROON, ALLEN_ROSE, ALLEN_ORANGE, ALLEN_OCHRE,
ALLEN_YELLOW) and semantic aliases (COLOR_BG_BASE, COLOR_TEXT_PRIMARY,
LINK_COLOR, etc.) so components can import named tokens instead of
raw hex values.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fixes "yarn: command not found" when committing via VS Code's git UI,
which doesn't inherit the shell PATH.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…iles

Adds --color-accent, --color-surface, --color-bg-dark, --color-feature,
--color-secondary to colors.css, then updates all module CSS files to
use semantic names instead of palette names (--ALLEN_BLUE, --PAGE_1,
--GRAY_2, --WHITE, --BLACK, etc.).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
meganrm and others added 18 commits May 21, 2026 15:05
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@netlify

netlify Bot commented Jun 2, 2026

Copy link
Copy Markdown

Deploy Preview for project-idea-board ready!

Name Link
🔨 Latest commit 9c47e0a
🔍 Latest deploy log https://app.netlify.com/projects/project-idea-board/deploys/6a1f53600b815c0008a7f9f4
😎 Deploy Preview https://deploy-preview-102--project-idea-board.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the “proposal” callout styling to reduce visual harshness by routing it through design tokens and switching the callout border to Allen orange.

Changes:

  • Update proposal callout styles to use --callout-box-* CSS tokens rather than --accent-color / --bg-dark-color.
  • Change --callout-box-border-color to --ALLEN_ORANGE.
  • Add a design spec documenting the callout color decision.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/style/theme.ts Updates Ant Design theme token usage for links (and contains a TS token mirror that should remain consistent with CSS tokens).
src/style/idea-post.module.css Wires .proposal to callout-box design tokens for background and left border.
src/style/colors.css Redirects the callout border token to --ALLEN_ORANGE.
docs/design/specs/2026-05-29-proposal-callout-color-design.md Documents rationale and exact token-based styling for the callout update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/style/theme.ts
Comment thread src/style/theme.ts
@meganrm meganrm requested review from ShrimpCryptid and rugeli June 2, 2026 23:38

@ShrimpCryptid ShrimpCryptid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a question about a file that was checked in. There are a few Copilot comments that seem relevant also?

@@ -0,0 +1,63 @@
# Proposal Callout Box — Color Update Design

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be persisted in the repo?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know, I'm unsure. On the one hand they are really just for the implementation so could be deleted, but on the other hand I can see having a history of rational and design might be helpful?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry a bit about having a folder that's constantly expanding with each new feature that's merged. I wish it could be captured in an issue or something outside of the repo itself.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? they're fairly small overall. I guess with a release I could have the docs combined, but I don't see what problem it would cause.

@meganrm meganrm requested a review from ShrimpCryptid June 5, 2026 18:41
@meganrm meganrm merged commit a4929a9 into main Jun 5, 2026
10 checks passed
@meganrm meganrm deleted the feature/style-adjustments branch June 5, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants