Repository navigation
fix: beacon-transport login_start so the event survives OAuth navigation - #65
Merged
Merged
Conversation
The GitHub login button immediately navigates to /api/auth/login; a batched gtag send races the unload and can drop login_start. transport_type:'beacon' is a gtag control field (consumed by the tag, never sent as an event param) that flushes via sendBeacon at emit time. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
login_startwas queued on the dataLayer butwindow.location.assignto/api/auth/loginraced the batched gtag flush — the event could be dropped.transport_type: 'beacon'is a gtag control field (consumed by the tag, never sent as an event param); the event now flushes viasendBeaconat emit time.Test plan
npm test476/0, typecheck cleanlogin_startcollect observable on clickGenerated with Devin