Repository navigation
fix: deny SDK $session_entry_*/$initial_* campaign properties - #61
Merged
Merged
Conversation
posthog-js stamps $session_entry_<param> and $initial_<param> for every campaign param it sees in the query string — a hostile URL like /?utm_source=SECRET therefore leaked utm values inside otherwise sanitized events. Enumerate every derived variant in the denylist and add a prefix-level guard so custom_campaign_params and future variants are covered too. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found during production QA of the Web Analytics tranche: a hostile URL like
?utm_source=SECRETleaked its value as$session_entry_utm_sourceinside$pageviewpayloads. posthog-js generates$session_entry_<param>/$initial_<param>dynamically for every campaign param it sees — the denylist only covered the bare names.$session_entry_/$initial_campaign variant.scrubEventPropertiesadditionally denies the$session_entry_/$initial_prefixes outright, coveringcustom_campaign_paramsand any future SDK variant.Identical fix already landed in
dev-ledger-site(c111efe).Test plan
SECRET/DO_NOT_SEND/privatein payloadGenerated with Devin