Repository navigation
fix(ui-egui): a click under a new page's date starts writing (#148) - #185
Merged
DWAA1660 merged 1 commit intoNov 12, 2026
Merged
Conversation
A new page's box holds only its date and is drawn tall, like OneNote's first note area, but nothing under the date took a click: the space looked ready for writing, no caret appeared, and what was typed was lost (AlienTechSoftware#148). A click there now adds a line under the date, in the same box, and puts the caret on it. Fixes AlienTechSoftware#148 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes #148. A new page's only box holds its date line, and
container_content_heightdeliberately draws that boxINITIAL_PAGE_LINEStall, which is the big outlined area the issue shows. The date paragraph is the only widget inside it, though, so a click anywhere below the date hit nothing. No caret appeared and typed text was lost. Only clicking the date itself (then Enter) worked.containers::shownow gives that blank area under the date its own click target, but only for a box whose single block is the page stamp (pageedit::is_page_stamp). A click there inserts an empty paragraph after the date in the same box and puts the caret on it, mirroring the existing handler that fills an empty box (start_in). Once the box holds more than the date it sizes to its content as before, so this only affects a fresh page.How it was checked
a_click_under_a_new_pages_date_starts_writing, for HTML and CMGFM pages created withnode.create:TEST EMPTY AREAis in the saved pagecaret: null, as in the issue), and passes with itcargo test -p notecraft-ui-egui: all pass (302 unit, 203 UI)cargo fmt --all -- --check,cargo clippy -p notecraft-ui-egui --all-targets -- -D warnings: clean🤖 Generated with Claude Code