Skip to content

[ALICE3] IOTOF: Digitization for the TOF3 #15372

Open
GiorgioAlbertoLucia wants to merge 26 commits intoAliceO2Group:devfrom
GiorgioAlbertoLucia:tf3_digit
Open

[ALICE3] IOTOF: Digitization for the TOF3 #15372
GiorgioAlbertoLucia wants to merge 26 commits intoAliceO2Group:devfrom
GiorgioAlbertoLucia:tf3_digit

Conversation

@GiorgioAlbertoLucia
Copy link
Copy Markdown
Contributor

@GiorgioAlbertoLucia GiorgioAlbertoLucia commented May 6, 2026 •
edited
Loading

@njacazio
First steps towards a full digitization for TOF3

  • GeometryTGeo class added, to move from the global coordinates to the local coordinate of a given chip
  • Segmentation class added, which finds the pixel position (row, col) on a chip, from the local chip coordinate
  • Digitizer class further developed, to process single hits and produce digits. Currently a flat efficiency and no checks on the created charge are considered

maciacco and others added 20 commits April 30, 2026 12:02
@maciacco
one sensor per chip
2b17981
@maciacco
one sensor per chip also in second layer
3b72641
@GiorgioAlbertoLucia
iotof segmentation and parameters. Segmentation parameters are stolen…
e0f57a7 
… from ALPIDE and probably nonsensical
@maciacco
compute number of chips in IOTOF
c072ae2
@maciacco
fill L2G transformation matrices
876f171
@maciacco
Merge pull request AliceO2Group#4 from GiorgioAlbertoLucia/tf3_digit
6ce0aa3 
iotof segmentation and parameters
@maciacco
fix cmakelist
684490f
@maciacco
only fill segmentation details if layout is segmented + add function …
abe83cb 
…to retrieve chip index
@maciacco
use proper chip id for segmented barrel
ce30af9
@GiorgioAlbertoLucia
refactoring of segmentation, idependent for inner and outer tof, nons…
0038f09 
…tatic
@GiorgioAlbertoLucia
singleton implementation of the segmentation class
728a505
@GiorgioAlbertoLucia
realistic values fot the chip segmentation
5924d18
@GiorgioAlbertoLucia
hit processing in place, tested on A3Studies/Digitization/testDigitiz…
bdbd1b8 
…ation.cpp
@GiorgioAlbertoLucia
clang format
175f4db
@GiorgioAlbertoLucia
protect against disks for now
ea0d674
@GiorgioAlbertoLucia
added sanity checks
e437ecf
@GiorgioAlbertoLucia
thickness that matches the values currently in O2
d4b2789
@GiorgioAlbertoLucia
default init of chipspecifics to zero
6a4c6c2
@GiorgioAlbertoLucia
double typo (half the honor)
31daa6d
@alibuild
Please consider the following formatting changes
213c808
@alibuild alibuild mentioned this pull request May 6, 2026
Merged
@GiorgioAlbertoLucia
Merge pull request #1 from alibuild/alibot-cleanup-15372
f30965d 
Please consider the following formatting changes to AliceO2Group#15372
@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review May 7, 2026 09:09
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 7, 2026

Error while checking build/O2/fullCI_slc9 for f30965d at 2026-05-07 13:28:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:79:7: error: use of undeclared identifier 'iRow'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:79:14: error: use of undeclared identifier 'iCol'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:80:7: error: void function 'detectorToLocalUnchecked' should not return a value [-Wreturn-type]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:90:7: error: use of undeclared identifier 'iRow'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:90:14: error: use of undeclared identifier 'iCol'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:91:7: error: void function 'detectorToLocalUnchecked' should not return a value [-Wreturn-type]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:100:7: error: use of undeclared identifier 'iRow'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:100:14: error: use of undeclared identifier 'iCol'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:101:7: error: void function 'detectorToLocalUnchecked' should not return a value [-Wreturn-type]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:115:7: error: use of undeclared identifier 'iRow'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:115:14: error: use of undeclared identifier 'iCol'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:130:7: error: use of undeclared identifier 'iRow'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:130:14: error: use of undeclared identifier 'iCol'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:144:7: error: use of undeclared identifier 'iRow'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:144:14: error: use of undeclared identifier 'iCol'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:177:5: error: void function 'localToDetectorUnchecked' should not return a value [-Wreturn-type]
Error: /sw/slc9_x86-64/ROOT/v6-36-04-alice9-30/bin/rootcling: compilation failure (/sw/BUILD/263733daeb824cffa11093e2e691b593b7aab018/O2/Detectors/Upgrades/ALICE3/IOTOF/simulation/G__O2IOTOFSimulation2e3116d5a2_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

@GiorgioAlbertoLucia
Fix row and column assignment in detector functions
42c13bf
@GiorgioAlbertoLucia
Change return type in segmentation function
2a32b97 
Updated return statement to remove false return value.
@GiorgioAlbertoLucia
Remove return statement from detectorToLocalUnchecked
6326fbe 
Updated detectorToLocalUnchecked methods to remove return type.
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 7, 2026

Error while checking build/O2/fullCI_slc9 for 2a32b97 at 2026-05-07 15:48:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:80:7: error: void function 'detectorToLocalUnchecked' should not return a value [-Wreturn-type]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:91:7: error: void function 'detectorToLocalUnchecked' should not return a value [-Wreturn-type]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Segmentation.h:101:7: error: void function 'detectorToLocalUnchecked' should not return a value [-Wreturn-type]
Error: /sw/slc9_x86-64/ROOT/v6-36-04-alice9-30/bin/rootcling: compilation failure (/sw/BUILD/263733daeb824cffa11093e2e691b593b7aab018/O2/Detectors/Upgrades/ALICE3/IOTOF/simulation/G__O2IOTOFSimulationc799bbc8df_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio enabled auto-merge (squash) May 7, 2026 15:32
njacazio
njacazio previously approved these changes May 7, 2026
View reviewed changes
@njacazio
Remove Mat3D alias from GeometryTGeo class
adbaeb1 
Removed the alias 'Mat3D' for 'o2::math_utils::Transform3D'.
@njacazio njacazio changed the title Digitization for the TOF3 [ALICE3] IOTOF: Digitization for the TOF3 May 7, 2026
@njacazio njacazio disabled auto-merge May 7, 2026 15:36
@njacazio njacazio enabled auto-merge (squash) May 7, 2026 15:36
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 7, 2026

Error while checking build/O2/fullCI_slc9 for 0dc1796 at 2026-05-07 21:28:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:180:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:182:40: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:184:47: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:188:39: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:190:40: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/IOTOF/base/src/GeometryTGeo.cxx:192:47: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GiorgioAlbertoLucia @alibuild @njacazio @maciacco