A compilation error is a verdict, not a failure to judge - #95
Merged
Conversation
The seed marked one `failed`, which is the state an infrastructure failure leaves. Adds the case that state is actually for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parity seed marked
team7's compilation errorfailed, which is the statean infrastructure failure leaves — the Runner never reports one for a
compilation error.
compilation_failedinaj-standard-ioreturnsEvaluated::Judgedwith a score andinfrastructureFailure: false, so theServer stores it
Completedwith 0.It matters now because the Client's ICPC board stops charging twenty penalty
minutes for a submission nobody returned a verdict for
(AlgoJudge/AlgoJudge-Client#…). Left as it was, this seed would have shown a
compilation error costing nothing, which is the opposite of what it costs.
Adds the row that state is actually for:
team7onD, an evaluation thatfailed with the judge's message and no verdict — the shape the board draws as
?. MirrorsAlgoJudge-Client/src/api/fake/fixtures/world.ts, which the twoseeds exist to keep identical.
Seed data only.
dotnet build -warnaserrorclean.