An attempt a rejudge overtook says so - #101
Merged
Merged
Conversation
A sixth job state. Telling a manager that somebody cancelled an attempt nobody cancelled is a misreading with nothing in the row to correct it. The fake supersedes the same way, or the screen check:ui drives disagrees with the Server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sixth job state,
superseded, for an attempt a rejudge replaced before a Runner picked it up.Not
cancelled, which a manager does on purpose and whichMANAGER_PANEL.mdstates as an action of theirs. Nothing is released, so the only argument for reusing it was the size of the change — against telling somebody reading an attempt list that a person cancelled an attempt nobody cancelled.The type system found two exhaustive
Record<JobState, string>maps, which is what those annotations are for.The submissions filter is deliberately unchanged. A submission's own badge follows its newest attempt and a rejudge always adds a newer one, so
supersedednever appears there — only in the attempt list.isFinishedgains it, andcancelledwith it: the Server refuses four states and this listed two, with the button's owndisabledmaking up one of the difference — so a cancelled attempt was correctly unclickable under a tooltip offering to cancel it.The fake supersedes the same way, or the screen
check:uidrives disagrees with the Server.tsc,check:i18n,check:apiagainst the regenerated document, andcheck:uiall green.