Add Magic Node copy and paste actions to node context menus - #231
Closed
kolibril13 wants to merge 1 commit into
Closed
Add Magic Node copy and paste actions to node context menus#231kolibril13 wants to merge 1 commit into
kolibril13 wants to merge 1 commit into
Conversation
Contributor
|
Taking a look at this now. |
Vollkornaffe
self-requested a review
September 1, 2026 15:35
Vollkornaffe
reviewed
Sep 1, 2026
Contributor
There was a problem hiding this comment.
Overall, I think this change is too complex for what it does.
Exporting this way also doesn't allow you to set external items.
Please consider this alternative approach.
It still pops up the dialog with the clipboard/file and compressed/JSON options, but it is significantly more straightforward and reuses existing logic.
Collaborator
Author
|
perfect! thanks so much for looking at this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a.mp4
b.mp4