Repository navigation
MPL-2.0, readable comments and defensive crypto fixes in 0.0.5 - #5
Merged
Merged
Conversation
AlexiAxAxA
marked this pull request as ready for review
September 26, 2026 08:50
AlexiAxAxA
marked this pull request as draft
September 26, 2026 09:04
AlexiAxAxA
marked this pull request as ready for review
September 26, 2026 10:06
AlexiAxAxA
marked this pull request as draft
September 26, 2026 10:34
AlexiAxAxA
marked this pull request as ready for review
September 26, 2026 10:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCrate and its application SDK move from Community License to MPL-2.0. The READMEs explain the supported APIs and license without commercial thresholds; repeated comment histories are shortened while wire formulas and security contracts remain.
The follow-up for coordinated 0.0.5 also fixes secret-bearing Debug output, recoverable RSA-OAEP data in freed heap limbs, zero-capacity streaming, changed recipient/chunk-size requests after planning, and noncanonical X-Wing Seal recipient keys. The original DH canonicalization and hybrid-key redaction fixes remain included. Raw X-Wing and frozen KAT/golden bytes are unchanged.
Validation: 693 core tests pass (15 existing ignored), warnings-denied Clippy/Rustdoc, pure-core WASM; 10 original regressions fail on the original public source and 11 additional regressions fail on 0.0.4. Two allocator checks fail on registry crypto 0.0.4 and pass after the fix. The bounded property harness passes 13 checks including 30,000 deterministic mutations. SDK: 7 tests and 8 native Python ABI checks pass.
All seven 0.0.5 packages are published under MPL-2.0. Downloaded src/README match release snapshot 1dd0d08; registry checksums, rendered MPL README and a fresh registry-only facade/SDK consumer pass. Release CI passes Linux/Windows and dependencies: https://github.com/AlexiAxAxA/OpenCrate/actions/runs/36234161293. SDK CI passes Rust, Python, Java and C++ checks. Earlier 0.0.4 does not contain the subsequent fixes.
The final readability follow-up shortens another 174 comment blocks across 58 Rust files. It preserves executable lines, SPDX notices and all 41 frozen artifacts byte for byte relative to the release snapshot. It also corrects stale assemble() return documentation and KEM-dependent KDF sizes. These later comments are in this PR, not in immutable 0.0.5 archives. Its fresh local workspace run passes 693 tests (15 existing ignored), Clippy and warnings-denied Rustdoc. Final CI on 50fb8d2 passes Linux/Windows, app-data, examples, WASM and dependencies: https://github.com/AlexiAxAxA/OpenCrate/actions/runs/36236411655. The refreshed export contains 176 verified file hashes, no content-boundary findings and no unexpected secret-scanner findings. See docs/review-2026-09-26.md for scope and limits; these checks are not an independent cryptographic audit or an instrumented fuzz campaign.