Repository navigation
feat(mvp4): React + MockCorePort - #76
Merged
Merged
Conversation
Ship MVP-4 offline flow (create→export) in React against a deterministic mock, reuse design tokens, refresh visual baselines, and document the slice with implementation-baseline-mvp4 readiness.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 927271db-6058-412f-a690-e1d8038342dd) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objetivo
Cerrar el slice MVP-4: UI React contra MockCorePort determinista, con CorePort TS alineado a los DTO Rust y design system sin rediseño.
IDs trazados
docs/10-delivery/mvp4-scope.md)Cambios
test-a11y:flow; go-no-go / backlog / next-issues del sliceFuera de alcance
Pruebas y evidencias
pnpm checken apps/webpnpm test-a11y,test-a11y:axe,test-a11y:visual,test-a11y:flowChecklist DoD
implementation-baseline-mvp4tras mergeNote
Medium Risk
Large front-end architecture swap and CorePort TypeScript contract changes affect Tauri integration and all web a11y/visual CI; behavior is mitigated by mock port and new E2E flow, but Rust/TS DTO alignment must stay in sync.
Overview
MVP-4 migrates
apps/webfrom a static HTML + imperative TypeScript shell to React (Vite) while keeping the same walking-skeleton UX (create → select → resolve → validate → manifest → export) and existing CSS tokens.The UI lives in a new
App.tsx;index.htmlis reduced to#root+main.tsx, which picksTauriCorePortwhen Tauri is present and otherwiseMockCorePortfor offline/CI. Vanillamain.tsandcomponents.tsare removed.coreport.tsis expanded with camelCase DTOs aligned to Rust, typed inputs/outputs, and shared helpers (FIXED_CATALOG_REF,withSelection, etc.); Tauri wiring moves totauri-core-port.ts.Testing & CI: adds
mock-flow.playwright.test.tsandpnpm test-a11y:flow(wired in.github/workflows/ci.yml); statica11y-check.pynow asserts a11y patterns againstApp.tsx. Traceability inventory links the mock flow to FR/NFR coverage. Governance docs record MVP-4 scope, closed issues, and baselineimplementation-baseline-mvp4. Playwright output paths are gitignored.Reviewed by Cursor Bugbot for commit eb8cd79. Configure here.