Repository navigation
feat(mvp3): adapters de exportación versionados - #74
Merged
Merged
Conversation
Separate archmaker-profile, experimental archinstall envelope, and report adapters so exportArtifact fulfills ADR-0003/FR-EXPORT-001 without runner or catalog signing. Fill Artifact.content and close the MVP-3 slice docs.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 79629b3d-915a-4cc9-833e-4c9f02911570) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objetivo
Cerrar el slice MVP-3: adapters de exportación versionados (ADR-0003 / FR-EXPORT-001) sin runner ni firma de catálogo.
IDs trazados
docs/10-delivery/mvp3-scope.md)export_adapters_diverge_bytes_and_fill_content, idempotencia, rechazo)Cambios
render_artifact_bytesseparaarchmaker-profile, sobre experimentalarchinstall-profileyreportArtifact.contentrelleno con el payload del adapterFuera de alcance
Contratos/migraciones
Sin cambio de enum de targets ni de schema
Artifact; solo semántica de exportación.Seguridad/privilegios
Sin superficie nueva de shell/red/disco. El sobre archinstall rechaza claves ejecutables.
Accesibilidad/visual
Sin cambios UI.
Pruebas y evidencias
cargo test -p archmaker-core --test core_contract(21 ok)cargo test -p archmaker-wasm --test parity(6 ok)python3 tools/gates.py→ ClearDocumentación
docs/10-delivery/mvp3-scope.md(DOC-DEL-MVP3-001)Checklist DoD
implementation-baseline-mvp3tras merge (MVP-3-06)Note
Medium Risk
Export semantics change (archinstall no longer mirrors archmaker bytes) and
Artifact.contentis now always set on successful export; contract tests cover divergence but downstream consumers must handle the new payloads.Overview
Delivers MVP-3: versioned export adapters (ADR-0003 / FR-EXPORT-001) without changing CorePort surface or adding runner/shell.
Core export behavior:
render_artifact_bytesnow returns aRenderedArtifact(bytes, media type, JSONcontent) and routes each target through its own renderer.archmaker-profilestays canonical manifest JSON;reportis deterministic markdown;archinstall-profileis a separate experimental JSON envelope (manifest ref + orderedeffectiveSelections), not a raw manifest re-export, with rejection if banned executable-shaped keys appear.export_artifactpopulatesArtifact.content, setsexperimental: trueonly for archinstall, and keeps byte-idempotentbinaryDigestbehavior.Tests & docs: New integration test
export_adapters_diverge_bytes_and_fill_content(divergent digests, content filled, envelope shape, no executable keys). Governance/delivery docs add MVP-3 scope, close MVP-3-01..06, baselineimplementation-baseline-mvp3, ADR-0003 marked partial; traceability inventory/matrix updated for the new test.Reviewed by Cursor Bugbot for commit d2eadb0. Configure here.