Fix save on tab close using wrong parent reference#5
Open
srfwb wants to merge 3 commits into
Open
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #4 -- TabManager could not save files when closing a tab or quitting
the app because it relied on finding action_save() on its parent widget.
That method does not exist on the parent (a QFrame container), so the save
was silently skipped and data was lost.
What changed
close_tab() and prompt_save_all() save the editor content directly via
file_manager.save_file() instead of looking for action_save() on a parent.
Additional fix: untitled tabs
While fixing the above, I discovered a pre-existing bug in the same code
path: closing an untitled tab (no file path) and clicking Save did nothing
-- the code was silently lost. This was never working because the original
action_save() lookup already failed on the QFrame parent.
close_tab() and prompt_save_all() now call file_manager.save_file_as()
for untitled tabs, which opens a Save As dialog. If the user cancels the
dialog, the tab stays open.
After fix