Fix silent save failure when file write is denied#3
Open
srfwb wants to merge 1 commit into
Open
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #2 — MeadowPy silently fails when saving a file it doesn't have write permission to. The unsaved dot disappears even though nothing was written to disk.
What changed
file_manager.py:save_file()now shows aQMessageBox.criticalerror dialog when the write fails (same style as existing error dialogs infile_explorer.py)workspace_controller.py:action_save()now checks the return value ofsave_file()— the modified flag and tab title are only updated on successImpact
All save paths that go through
action_save()are fixed:Save Aswas already handling failure correctly.After fix