Skip to content

Fix landing scrollbar, add mailEnabled setting, move to Node 24 and drop dotenv/nodemon/body-parser/generate-password/axios - #38

Merged
AlexDeveloperUwU merged 6 commits into
v2from
claudio/dazzling-newton-cefogi
Nov 3, 2026
Merged

AlexDeveloperUwU merged 6 commits into
v2from
claudio/dazzling-newton-cefogi

Conversation

@AlexDeveloperUwU

@AlexDeveloperUwU AlexDeveloperUwU commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Landing scrollbar: IndexView used min-h-screen inside a container that already pads for the fixed navbar, so the page overflowed by 3.5rem. Now min-h-[calc(100vh-3.5rem)].
  • Mail toggle: new mailEnabled config (seeded false; set to true on boot for installs that already have host/user/password). Settings shows SMTP fields only when enabled; the mailer skips sending when disabled. gl/es/en locales updated.
  • Node 24: Dockerfile, engines, .nvmrc, nvm script, @types/node@24, CLAUDE.md.
  • Unused deps removed: jsonwebtoken, luxon, pino-http-print, @types/swagger-jsdoc, cookie-parser; client dayjs, luxon, calendarize, vue-loading-overlay.
  • Libraries replaced by native APIs (one commit each, so each can be reverted alone):
    • dotenv -> util.parseEnv + process.loadEnvFile (index.js reads process.env.MYSQL_*, so the file is still exported to process.env, without overriding existing vars). A missing creds file now fails with a clear ENOENT instead of a TypeError.
    • body-parser -> express.json / express.urlencoded (same 15mb limits).
    • generate-password -> crypto.randomInt (same 92-char pool, 12 chars, all four classes required).
    • nodemon -> node --watch (follows the import graph, so client/ and data/ writes don't restart it).
    • client axios -> client/src/utils/http.js, a fetch wrapper with the same call and error shape. The 401 interceptor became setUnauthorizedHandler in main.js. Client bundle 310 kB -> 261 kB.

How it was verified

MariaDB 10.11 (no Docker daemon here), freshly reset DB for each run, Node 24. The pre-migration commit (76a558e) and the final head were each run through:

  • A 24-request API smoke script (login/logout, cookies, config, CRUD, 5MB JSON, urlencoded, 16MB -> 413, bad JSON, unauth): status codes, Set-Cookie and response shapes identical.
  • A Playwright flow on the real built app (bad/good login, settings toggle + save + reload, all list pages, create space via UI, session expiry -> redirect to /): identical network calls and state; screenshots identical except random ids / timestamps in tables.
  • 20k-password statistical check of the new generator (policy, length, per-character distribution) against the library.
  • node --watch: restarts on a server file edit, not on client/ or data/ writes.
  • Multipart event image upload through the new http client (201, cover converted to AVIF).
  • client build + eslint clean.

Not tested: docker build (no Docker daemon), real SMTP delivery.

🤖 Generated with Claude Code

https://claude.ai/code/session_016GiW7iwZTVBrRoz9KEvyP8

- Landing page: use min-h-[calc(100vh-3.5rem)] so it no longer overflows the fixed navbar
- Settings: new mailEnabled config; SMTP fields only shown when enabled; mailer skips sending when disabled
- Node 24 (Dockerfile, engines, .nvmrc, @types/node); remove unused deps (jsonwebtoken, luxon, pino-http-print, @types/swagger-jsdoc, cookie-parser; client dayjs, luxon, calendarize, vue-loading-overlay)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GiW7iwZTVBrRoz9KEvyP8
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GiW7iwZTVBrRoz9KEvyP8
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GiW7iwZTVBrRoz9KEvyP8
Same call shape and error shape (error.response / error.request), multipart
uploads let the browser set the boundary, and the 401 session-expiry handling
moves from an axios interceptor to setUnauthorizedHandler in main.js.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GiW7iwZTVBrRoz9KEvyP8
@AlexDeveloperUwU AlexDeveloperUwU changed the title Fix landing scrollbar, add mailEnabled setting, move to Node 24 Fix landing scrollbar, add mailEnabled setting, move to Node 24 and drop dotenv/nodemon/body-parser/generate-password/axios Nov 2, 2026
@AlexDeveloperUwU
AlexDeveloperUwU marked this pull request as ready for review November 3, 2026 09:50
@AlexDeveloperUwU
AlexDeveloperUwU merged commit be8544e into v2 Nov 3, 2026
2 checks passed
@AlexDeveloperUwU
AlexDeveloperUwU deleted the claudio/dazzling-newton-cefogi branch November 3, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants