Repository navigation
feat(mail): Generate email icons dynamically from any Lucide icon - #35
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016GiW7iaZejGqmwEXmq9wvF
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016GiW7iaZejGqmwEXmq9wvF
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016GiW7iaZejGqmwEXmq9wvF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureIcon(name, color)resolves the icon straight fromlucide-staticby name, so new templates can use any LucidetitleIcon/infoIconwith no registration step; the hardcodedICONSmap is removed.accent(default#2159a3), so existing emails keep their colors. It's part of the cached filename (<icon>-<hex>.png), so the same icon in different colors doesn't collide.Unknown Lucide icon "x"...) instead of a destructuring crash. Names and colors are validated (kebab-case / hex), which also blocks path traversal and SVG injection.npm run email:iconsnow clears the icon cache and rebuilds the brand icon (icons regenerate lazily).Test plan
circle-checkin two colors produces two distinct PNGs; an unregistered icon (rocket) generates fine../x, and non-hex color each throw a clear errornode emails/generate-icons.mjsruns cleanlyGenerated by Claude Code