Combine the listArchiveCourses and statArchiveCourses methods.#37
Merged
Alex-Jordan merged 1 commit intoJul 9, 2026
Merged
Conversation
The `listArchiveCourses` also stats the archive files found and returns the files as a hash whose keys are the course ids and the values are references to hashes containing the `filename` (the basename of the file including the `.tar.gz` extension) and file `size` Both of the places that use the `listArchiveCourses` method are updated to use this return value.
drgrice1
force-pushed
the
archive-sizes-suggestion
branch
from
372d125 to
da34ce9
Compare
Author
|
I also added some basic rounding to the archive file size instead of just converting to an int. This is only done for MB and GB sizes. Basicall, MB sizes are rounded to one decimal place, and GB sizes to two. Looking at my archive lists the MB and GB sizes (actually I don't have any GB sizes currently) just seemed off. I was just seeing several |
Owner
|
Thanks for making the changes for me. I've merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
listArchiveCoursesalso stats the archive files found and returns the files as a hash whose keys are the course ids and the values are references to hashes containing thefilename(the basename of the file including the.tar.gzextension) and filesizeBoth of the places that use the
listArchiveCoursesmethod are updated to use this return value.